Move and retry flaky scan test #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamagoko
approved these changes
Nov 4, 2024
bluesliverx
approved these changes
Nov 4, 2024
shanejbrown
commented
Nov 4, 2024
| _get_test_runs(test_dir=f"{TEST_DIR}/test-files/arm-arch", serial_tests=True), | ||
| _get_test_runs(test_dir=f"{TEST_DIR}/test-files/scan", serial_tests=False), | ||
| ) | ||
| def test_serial_buildrunner_arm_dir(test_dir: str, file_name, args, exit_code): |
Contributor
Author
There was a problem hiding this comment.
There are no files for test_serial_buildrunner_arm_dir to run. So I removed this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I have noticed in github that I am semi-frequently seeing the same "tests/test_buildrunner_files.py::test_serial_buildrunner_dir[/home/runner/work/buildrunner/buildrunner/tests/test-files-test-security-scan.yaml-args2-0]" test fail. The error is:
This change will attempt to retry the test if it fails one time. On the 2nd failure it produce the failure as normal.
What issues does this PR fix or reference?
Previous Behavior
New Behavior
Merge requirements satisfied?
setup.py(if appropriate).